Solve the staging compiler regression and enhance the docker container execution in script/tools#3634
Merged
Solve the staging compiler regression and enhance the docker container execution in script/tools#3634
Conversation
ThomasNing
requested review from
Snektron,
afagaj,
andriy-ca,
aosewski,
asleepzzz,
bartekxk,
carlushuang,
cgmillette,
coderfeli,
geyyer,
illsilin,
poyenc,
qianfengz,
shumway,
tenpercent,
vidyasagar-amd and
vpietila-amd
as code owners
illsilin
approved these changes
Jan 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a CTAD (Class Template Argument Deduction) regression and introduces comprehensive Docker management tools for Composable Kernel testing.
Changes:
- Removed CTAD deduction guide from
BlockReduce2Dthat was causing compilation issues - Fixed
BlockSoftmax2Dto explicitly specify template argument instead of relying on CTAD - Added a suite of shell scripts (
ck-*) for Docker-based development workflow including build, test, status, and container management utilities - Removed trailing comment marker in
mx_flatmm_pipeline_agmem_bgmem_creg_v1_policy.hpp
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| include/ck_tile/ops/reduce/block/block_reduce.hpp | Removed CTAD deduction guide to resolve regression |
| include/ck_tile/ops/softmax/block/block_softmax_2d.hpp | Added explicit template argument to fix CTAD-related compilation issue |
| include/ck_tile/ops/flatmm/pipeline/mx_flatmm_pipeline_agmem_bgmem_creg_v1_policy.hpp | Cleaned up trailing comment marker |
| script/tools/ck-test | New utility for building and running tests in Docker |
| script/tools/ck-stop | New utility for stopping and removing Docker containers |
| script/tools/ck-status | New utility for checking container status and information |
| script/tools/ck-start | New utility for starting Docker containers |
| script/tools/ck-shell | New utility for opening interactive shell sessions |
| script/tools/ck-logs | New utility for viewing container and build logs |
| script/tools/ck-exec | New utility for executing arbitrary commands in containers |
| script/tools/ck-clean | New utility for cleaning build artifacts |
| script/tools/ck-build | New utility for building Composable Kernel targets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| Common Commands: | ||
| ck-exec rocm-smi # Check GPU status | ||
| ck-exec rocminfo \| grep gfx # Check GPU architecture |
There was a problem hiding this comment.
The pipe character should not be escaped in the comment. It should be '|' instead of '|'.
Suggested change
| ck-exec rocminfo \| grep gfx # Check GPU architecture | |
| ck-exec rocminfo | grep gfx # Check GPU architecture |
ThomasNing
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR has two features:
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered